make-3.81rc1 - Cygwin bugs, test errors

[gk]

Here is a summary of problems experienced installing and testing GNU Make 
3.81rc1 on CYGWIN_NT-5.1 x2 1.5.19(0.150/4/2) i686

Please let me know if you would like me to run further tests or provide 
more details.

NOTE: from the tests/README file:
>GNU make test suite:
        I verified all functionality with a slightly modified version
        of make-test-3.81rc1 (modifications to get test suite to run
        on Windows NT). All tests pass in an environment that includes
        sh.exe.  Tests were performed on both Windows NT and Windows 95.

FILE NOT FOUND:
make-test-3.81rc1

QUESTION:
What modifications can I make to the tests to get them to work on Cygwin?

Thanks for this test release!
- Greg

---
I have all the latest (as of 2006.02.23) required cygwin packages installed

address@hidden tests]$ echo $PATH
/cygdrive/c/greg/bin:/cygdrive/c/greg/xmake/bin:/usr/local/bin:/usr/bin:/bin:/us
r/X11R6/bin:/usr/bin:/cygdrive/c/Perl/bin/:/cygdrive/c/WINDOWS/system32:/cygdriv
e/c/WINDOWS:/cygdrive/c/WINDOWS/System32/Wbem:/cygdrive/c/PROGRA~1/COMMON~1/SONI
CS~1/:/cygdrive/c/PROGRA~1/COMMON~1/Odbc/FILEMA~1:/cygdrive/c/Program 
Files/Ultr
aEdit:/cygdrive/c/Program Files/Java/jre1.5.0_06/bin/client/:.:"C:/Program 
Files
/ZoneAlarm/MailFrontier":/cygdrive/c/Program 
Files/QuickTime/QTSystem/:/cygdrive
/e/Docs/Windows Shell Scripts

---

Followed the procedure in INSTALL file.
Some of the problems are documentation errors; others more serious.

[Some of the comments below may seem nit-picky to some but I am a QA guy by 
trade: if there is a correct way to word things so that a procedure should 
not fail, it is better to use correct words than ambiguous ones or those 
that will fail some of the time.]

----
STEP 1: type ./configure ...
RESULT: Success; no errors or warnings

COMMENTS: I followed procedure in README.W32 file:
>...define the HAVE_CYGWIN_SHELL in config.h

NOTE: contrary to steps below, this step explains the exact and correct 
command to use

----
STEP 2:  Type `make' to compile the package.
RESULT: FAILURE

COMMENTS: No existing make

>>> DOCUMENTATION BUG:
INSTALL file makes no mention of using build.sh when there is no existing 
make installed.
This should be added for the sake of those who might not have noticed this 
detail buried deep in README.W32

STEP 2 SHOULD BE:
Type `make' or `build.sh' to compile the package.

RESULT: Success; no errors or warnings

---
STEP 3:  type `make check' to run any self-tests ...
RESULT: FAILURE

COMMENTS:
Although '.' is in my $PATH, 'make check' and 'make install'  fail in 
recursive make;
'./make' is required, at this point.

address@hidden make-3.81rc1]$ make check
Making check in glob
/bin/sh: line 17: make: command not found
make: *** [check-recursive] Error 1
address@hidden make-3.81rc1]$ which sh
/usr/bin/sh
address@hidden make-3.81rc1]$ ln -s /usr/bin/sh /bin/sh
ln: creating symbolic link `/bin/sh.exe' to `/usr/bin/sh.exe': File exists
address@hidden make-3.81rc1]$ /bin/sh --version
GNU bash, version 3.00.16(14)-release (i686-pc-cygwin)

>>> DOCUMENTATION BUG:
INSTALL file should say:
type `./make check' to run any self-tests ...

---
STEP 4:  Type `make install' to install the programs ...
RESULT: FAILURE

COMMENTS:
Cause is same as above
'./make' is required, at this point.

address@hidden make-3.81rc1]$ make install
Making install in glob
/bin/sh: line 17: make: command not found
make: *** [install-recursive] Error 1

>>> DOCUMENTATION BUG:
INSTALL file should say:
type `./make install'  to install the programs ...

STEP 4 REVISITED:  Type `./make install' to install the programs ...
RESULT: Success. No errors or warnings.

---
STEP 3 - REVISITED (after running './make install'): 'make check'
RESULT: FAILURE

SUMMARY of FAILURES:

1. glob.c:197: warning: passing arg 1 of `my_realloc' from incompatible 
pointer type
Several similar warnings
2. features/default_names ..................................
*** Test died (features/default_names): test_driver.pl: 453: abort at 
test_drive
r.pl line 638.
3. features/escape ......................................... FAILED (5/6 
passed)

DETAIL:

Below I list only relevant lines indicating FAILURES (successes are omitted)

make[1]: Entering directory `/cygdrive/c/greg/src/make-3.81rc1/glob'
source='glob.c' object='glob.o' libtool=no \
        DEPDIR=.deps depmode=none /bin/sh ../config/depcomp \
        gcc -DHAVE_CONFIG_H -I. -I. -I..     -g -O2 -c glob.c
In file included from glob.c:1375:
glob.c: In function `glob_in_dir':
glob.c:197: warning: passing arg 1 of `my_realloc' from incompatible 
pointer typ
e
In file included from glob.c:810:
glob.c: In function `glob':
glob.c:197: warning: passing arg 1 of `my_realloc' from incompatible 
pointer typ
e
In file included from glob.c:929:
glob.c:197: warning: passing arg 1 of `my_realloc' from incompatible 
pointer typ
e
In file included from glob.c:985:
glob.c:197: warning: passing arg 1 of `my_realloc' from incompatible 
pointer typ
e
source='fnmatch.c' object='fnmatch.o' libtool=no \
        DEPDIR=.deps depmode=none /bin/sh ../config/depcomp \
        gcc -DHAVE_CONFIG_H -I. -I. -I..     -g -O2 -c fnmatch.c
rm -f libglob.a
ar cru libglob.a glob.o fnmatch.o
ranlib libglob.a
make[1]: Leaving directory `/cygdrive/c/greg/src/make-3.81rc1/glob'
Making check in config
...

Finding tests...

features/comments ....................................... ok     (1 passed)
features/conditionals ................................... ok     (4 passed)
features/default_names ..................................
*** Test died (features/default_names): test_driver.pl: 453: abort at 
test_drive
r.pl line 638.

ok     (4 passed)
...

features/escape ......................................... FAILED (5/6 passed)
...

2 Tests in 2 Categories Failed (See .diff files in work dir for details) :-(

make[2]: *** [check-regression] Error 1
make[2]: Leaving directory `/cygdrive/c/greg/src/make-3.81rc1'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/cygdrive/c/greg/src/make-3.81rc1'
make: *** [check-recursive] Error 1

>>> TEST DRIVER BUG: tests/test_driver.pl
Output from test_driver.pl says 'ok (4 passed)' when, in fact it also says:
>*** Test died (features/default_names): test_driver.pl: 453: abort at 
test_drive
r.pl line 638.

---
STEP 6:
I attempted to diagnose the errors, based on comment above 'See .diff files 
in work dir for details'

address@hidden make-3.81rc1]$ cd work
bash: cd: work: No such file or directory

address@hidden make-3.81rc1]$ ls *.diff
ls: *.diff: No such file or directory


>>> DOCUMENTATION BUG:

tests/README says:
>A directory named "work" will be created when the tests are run which
will contain any makefiles and "diff" files of tests that fail so that

NOTE: './make check' is run from the top level directory

tests/README SHOULD SAY:
>A directory named "tests/work" will be created when the tests are run ...

Found the 'diff' files in question:
 tests/work/features/default_names.diff.1
 tests/work/features/ escape.diff.2

--- BEGIN FILE CONTENTS: tests/work/features/default_names.diff.1

*** work/features/default_names.base.1  Fri Feb 24 03:14:32 2006
--- work/features/default_names.log.1   Fri Feb 24 03:14:32 2006
***************
*** 1 ****
! It chose makefile
--- 1 ----
! It chose Makefile

--- END FILE CONTENTS

--- BEGIN FILE CONTENTS: tests/work/features/ escape.diff.2

*** work/features/escape.base.2 Fri Feb 24 03:14:51 2006
--- work/features/escape.log.2  Fri Feb 24 03:14:51 2006
***************
*** 1 ****
--- 1,3 ----
+ make: stat: p:foo: No medium found
  cp p:foo
+ make: stat: p:foo: No medium found

--- END FILE CONTENTS

STEP 7: run_make_tests
RESULT: TWO additional FAILURE cases found, in addition to the two found by 
'make check'

address@hidden tests]$ ./run_make_tests
...
features/parallelism .................................... FAILED (4/6 passed)
...
4 Tests in 3 Categories Failed (See .diff files in work dir for details) :-(



- Greg Keraunen
http://www.xmake.org