Re: bug in 4.14: LDFLAGS ignored

[Thomas Klausner]

Hi Nikos!

Thanks for the reply. I had thought the mail was clear enough, but
I'll try to make it even clearer: please apply the attached patch.

As you can see in the patch context, the Makefile.am _overwrites_
LDFLAGS without taking into account the LDFLAGS passed in from the
environment. That breaks e.g. RELRO builds.

Thanks,
 Thomas

On Mon, Nov 04, 2019 at 04:27:47PM +0100, Nikos Mavrogiannopoulos wrote:
> Hi Thomas,
>  What you are suggesting does not look like a valid .am file. Checking
> the generated Makefile both AM_LDFLAGS and LDFLAGS are being passed to
> linker. Could it be that your issue is something unrelated?
> 
> regards,
> Nikos
> 
> On Mon, Nov 4, 2019 at 2:47 PM Thomas Klausner <address@hidden> wrote:
> >
> > Hi!
> >
> > New in 4.14, the LDFLAGS that are passed via the environment are
> > ignored.
> >
> > Please apply the following change to src/Makefile.am.
> >
> > -LDFLAGS = $(CODE_COVERAGE_LDFLAGS)
> > +LDFLAGS = $(CODE_COVERAGE_LDFLAGS) @LDFLAGS@
> >
> > Thanks,
> >  Thomas
> >
> > (I'm not subscribed.)
> >
>

patch-src_Makefile.am
Description: Text document