Re: [PATCH 1/3] Make _asn1_ordering_set_of() really sort.

[Kurt Roeckx]

On Sun, Apr 27, 2014 at 07:27:23PM +0200, Nikos Mavrogiannopoulos wrote:
> On Sun, 2014-04-27 at 18:42 +0200, Kurt Roeckx wrote:
> > On Sun, Apr 27, 2014 at 06:38:46PM +0200, Nikos Mavrogiannopoulos wrote:
> > > > Test_tree loads one that is not correctly sorted, encodes it as
> > > > DER at which points it gets sorted and then decodes it again.  As
> > > > far as I can see that decoded version is correctly sorted.
> > > 
> > > I see, but that as you say it works with both the current version and
> > > yours. Are there cases where your version would work and the current
> > > wouldn't?
> > 
> > I have no idea yet.  I've been trying to understand how the
> > current code works, but I'll need some more time.
> 
> Ok, thanks. Feel free to rewrite parts if you think that it will
> simplify things. The current code is pretty verbose and not always easy
> to understand.

So after reading it again, it makes sense now, and the old code
should just work, so feel free to ignore this patch.


Kurt