help-libtasn1
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Checking errors in the asn1_order functions


From: Kurt Roeckx
Subject: Checking errors in the asn1_order functions
Date: Sat, 19 Apr 2014 23:47:14 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Hi,

I was looking at the asn1_order_* functions who can detect errors
and let them return it.  See the attached patch.

I'm not sure I'm always using the correct error codes.

Anyway, the patch breaks the test suite.  I get:
FAIL: Test_tree
===============

./Test_tree.asn:121: Warning: VisibleString is a built-in ASN.1 type.
./Test_tree.asn:123: Warning: NumericString is a built-in ASN.1 type.
./Test_tree.asn:125: Warning: IA5String is a built-in ASN.1 type.
./Test_tree.asn:127: Warning: TeletexString is a built-in ASN.1 type.
./Test_tree.asn:129: Warning: PrintableString is a built-in ASN.1 type.
./Test_tree.asn:131: Warning: UniversalString is a built-in ASN.1 type.
./Test_tree.asn:134: Warning: BMPString is a built-in ASN.1 type.
./Test_tree.asn:138: Warning: UTF8String is a built-in ASN.1 type.
Error at line 661
ERROR in 139:
  Action 6 -  - (null) - 151
  Error expected: MEM_ERROR
  Error detected: DER_ERROR


I currently don't understand the test suite, so I have no idea
whether it's a problem or not that the error code changes.o


Kurt

Attachment: 0001-Make-_asn1_ordering_set-and-_asn1_ordering_set_of-re.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]