Re: [PATCH] cleanup _asn1_copy_structure3

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> Nikos Mavrogiannopoulos <address@hidden> writes:
>
>> On 09/10/2012 09:24 AM, Simon Josefsson wrote:
>>
>>> I agree -- and considered doing this when we did the 'small_value' (see
>>> int.h) change that we did earlier.  However, I think actually GnuTLS was
>>> one consumer of the node_asn_struct...  I think it was only in some
>>> X.509 Name functions contributed by Howard Chu, so perhaps we can
>>> rewrite only those parts.
>>> With that fixed, I think we could roll a libtasn1 3.x branch that
>>> removed the struct, and move on from there...  that would allow a
>>> rewrite of the internal tree stuff without breaking API/ABI.
>>
>>
>> I've added asn1_read_node_value() to use it in gnutls' functions and
>> removed the internal structure.
>
> I think we need a libtasn1 2.x branch going forward, could that function
> be added there?  It would be great if GnuTLS could be build with both
> libtasn1 2.x and 3.x, to allow people some time to migrate from 2.x to
> 3.x.

I've created a branch 'libtasn1_2_x' now.

/Simon