Re: [PATCH] cleanup _asn1_copy_structure3

[Nikos Mavrogiannopoulos]

On 08/31/2012 04:23 PM, Tim Ruehsen wrote:

> Hi,
> 
> a patch to simplify/cleanup _asn1_copy_structure3().

I noticed that you moved the check
+         if (p_s == source_node)
+           break;

within the if (move != UP). Couldn't this occur otherwise?

By seeing the _asn1_copy_structure2() and its usage from
asn1_create_element(), it seems there can be quite some optimizations by
adding a new asn1_create_element2() and a new asn1_array2tree2().
The newc array2tree should create a special tree that is easy to copy.
It doesn't look like much work, but I cannot afford it now at least.

regards,
Nikos