[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tarball installation problems
From: |
Alfred M. Szmidt |
Subject: |
Re: Tarball installation problems |
Date: |
Fri, 10 Jan 2003 23:26:50 +0100 |
I had a "--readonly" option in my menu.lst file like this (to work
around a bug that seems to have gone away):
No wonder why it didn't boot.
But I would consider this a minor bug, I think that init should be
more graceful and not just reboot. It could issue a nice error
message if it fails to run console-run, and loop until a key is
pressed. Doing an assert is bad I think, something like this maybe?
It could note that the file-system is read-only, but that should be
obvious by the previous messages (can't create a file, file-system
read-only, etc).
This of not tested.
2003-01-10 Alfred M. Szmidt <ams@kemisten.nu>
* init.c (start_child): Issue an error message (and loop forever)
if creating a console fails instead of doing an assert.
--- init.c.~1.129.~ 2002-05-08 16:02:18.000000000 +0200
+++ init.c 2003-01-10 23:20:57.000000000 +0100
@@ -1028,7 +1028,14 @@
err = argz_create ((char **) argv, &args, &arglen);
}
}
- assert_perror (err);
+
+ if (err)
+ {
+ error (0, err, "could not create a console");
+ /* Loop forever or untill someone presses the reboot button. */
+ for (;;)
+ ;
+ }
file = file_name_lookup (args, O_EXEC, 0);
if (file == MACH_PORT_NULL)