help-gsl
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-gsl] [PATCH] GSL_VERSION_MAJOR, GSL_VERSION_MINOR numeric mac


From: Leo Razoumov
Subject: Re: [Help-gsl] [PATCH] GSL_VERSION_MAJOR, GSL_VERSION_MINOR numeric macros
Date: Mon, 18 Jan 2010 13:13:52 -0500

On 2010-01-18, Brian Gough <address@hidden> wrote:
> At Fri, 15 Jan 2010 10:32:34 -0600,
>
> Rhys Ulerich wrote:
>  > Attached is a patch like Leo's that performs the autoconf voodoo to
>  > get the version numbers automatically from VERSION at configure time.
>  > It builds atop head.  Note that it uses AC_PROG_SED, which may/may not
>  > be an issue depending on GSL's portability requirements.
>
>
> I've checked in a change for this ffb8708d2cf636801de0b9f1f03c65a5ab0bcb13

Brian,
thanks for applying the patch. But I think that a proper attribution
to the patch author "Rhys Ulerich" <address@hidden> would be
nice. It is too late to change the "Author:" field of the git commit
(the commit is already published) but the ChangeLog file should have a
proper attribution to Rhys. Unlike git commit, it is never too late to
modify a file.

--Leo--




reply via email to

[Prev in Thread] Current Thread [Next in Thread]