Re: [Help-gsl] [PATCH] GSL_VERSION_MAJOR, GSL_VERSION_MINOR numeric macros

[Rhys Ulerich]

> Added GSL_VERSION_MAJOR, GSL_VERSION_MINOR macros with numeric constant
> values usable in preprocessor conditionals.
>
> Signed-off-by: Leo Razoumov <address@hidden>

Hi Leo,

It looks like the existing GSL_VERSION #define was set automagically
by autoconf via @address@hidden  The patch you submitted seems to hard code
two fixed values.

You probably want to automatically pick up the major and minor
versions at autoconf time by splitting @VERSION@ at configure time via
a macro like AX_SPLIT_VERSION
(http://ac-archive.sourceforge.net/ac-archive/ax_split_version.html).
Once you've got AX_SPLIT_VERSION working, then you'd AC_DEFINE
variables like VERSION_MAJOR, VERSION_MINOR, VERSION_POINT and then
stuff @VERSION_MAJOR@, etc in your new #define lines.

- Rhys

On Thu, Jan 14, 2010 at 5:06 PM, Leo Razoumov <address@hidden> wrote:
> ---
>  gsl_version.h.in |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/gsl_version.h.in b/gsl_version.h.in
> index 25bf3a3..c95f96f 100644
> --- a/gsl_version.h.in
> +++ b/gsl_version.h.in
> @@ -17,6 +17,9 @@ __BEGIN_DECLS
>
>  #define GSL_VERSION "@VERSION@"
>
> +#define GSL_VERSION_MAJOR 1
> +#define GSL_VERSION_MINOR 13
> +
>  GSL_VAR const char * gsl_version;
>
>  __END_DECLS
> --
> 1.6.5.7.LR1
>
>
>
> _______________________________________________
> Help-gsl mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/help-gsl
>