Re: GRUB 2.00 make fails

[Barry Jackson]

On 20/07/13 20:42, Kai Poeritz wrote:
> I try to build GRUB 2.00 from ftp://ftp.gnu.org/gnu/grub/grub-2.00.tar.gz
>
> I am on Arch-Linux amd64 with
>
> glibc 2.17
> gcc 4.8.1
>
> When I run make I get this error:
>
> # make
> make  all-recursive
> make[1]: Entering directory `/boot/grub/TEST/grub-2.00'
> Making all in grub-core/gnulib
> make[2]: Entering directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> make  all-recursive
> make[3]: Entering directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> make[4]: Entering directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl    -MT argp-eexst.o -MD
> -MP -MF .deps/argp-eexst.Tpo -c -o argp-eexst.o argp-eexst.c
> In file included from argp.h:22:0,
>                   from argp-eexst.c:25:
> ./stdio.h:456:1: error: 'gets' undeclared here (not in a function)
>   _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
>   ^
> make[4]: *** [argp-eexst.o] Error 1
> make[4]: Leaving directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/boot/grub/TEST/grub-2.00/grub-core/gnulib'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/boot/grub/TEST/grub-2.00'
> make: *** [all] Error 2
>
> All I could find was this related but unanswered question:
>
> http://lists.gnu.org/archive/html/help-grub/2012-10/msg00008.html
>
> Please help be to build GRUB and find out what causes this error.
>
> Thanks
>
> _______________________________________________
> Help-grub mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/help-grub

Try this patch:-

--- grub-core/gnulib/stdio.in.h~        2012-09-17 19:30:25.951421145 +0100
+++ grub-core/gnulib/stdio.in.h 2012-09-17 19:30:25.965421146 +0100
@@ -140,9 +140,10 @@
 /* It is very rare that the developer ever has full control of stdin,
    so any use of gets warrants an unconditional warning.  Assume it is
    always declared, since it is required by C89.  */
+#if defined gets
 #undef gets
 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
-
+#endif
 #if @GNULIB_FOPEN@
 # if @REPLACE_FOPEN@
 #  if !(defined __cplusplus && defined GNULIB_NAMESPACE)