Re: Grub v2.00 beta4 cannot grub-install

[Jordan Uggla]

On Fri, Apr 20, 2012 at 9:58 AM, Goh Lip <address@hidden> wrote:
> On 04/20/12 23:50, Goh Lip wrote:
>>
>> Downloaded and make install grub v2.00 beta4.
>> Confirmed installation complete withour error with "grub-install -v"
>> which gives "grub-install (GRUB) 2.00~beta4"
>>
>> However when I "sudo grub-install /dev/sda",
>> the following error message appears...
>> "/usr/local/sbin/grub-bios-setup: error: cannot write to `/dev/sda': Bad
>> file descriptor."
>>
>> Submitted bug report
>> https://savannah.gnu.org/bugs/index.php?36258
>>
>
> An almost immediate reply :
>
>  >                   Status:                    None => Wont Fix
>>
>>             Open/Closed:                    Open => Closed

That was supposed to be supposed to be (and now is) "Fixed" rather
than "Won't Fix". The diff for the commit in question which fixes this
is below.


=== modified file 'ChangeLog'
--- ChangeLog   2012-04-19 09:34:43 +0000
+++ ChangeLog   2012-04-19 18:35:06 +0000
@@ -1,5 +1,10 @@
 2012-04-18  Vladimir Serbinenko  <address@hidden>

+       * grub-core/kern/emu/hostdisk.c (grub_util_biosdisk_write): Fix opening
+       mode.
+
+2012-04-18  Vladimir Serbinenko  <address@hidden>
+
        * configure.ac: Bump to beta4.

 2012-04-18  Vladimir Serbinenko  <address@hidden>

=== modified file 'grub-core/kern/emu/hostdisk.c'
--- grub-core/kern/emu/hostdisk.c       2012-04-18 21:48:52 +0000
+++ grub-core/kern/emu/hostdisk.c       2012-04-19 18:35:06 +0000
@@ -1081,7 +1081,7 @@
     {
       int fd;
       grub_disk_addr_t max = ~0ULL;
-      fd = open_device (disk, sector, O_RDONLY, &max);
+      fd = open_device (disk, sector, O_WRONLY, &max);
       if (fd < 0)
        return grub_errno;