[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: UI glitch with text-scale-increase / text-scale-decrease with linum
From: |
Stefan Monnier |
Subject: |
Re: UI glitch with text-scale-increase / text-scale-decrease with linum / nlinum |
Date: |
Mon, 09 Feb 2015 09:57:08 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> (global-set-key (kbd "<C-mouse-4>") 'text-scale-increase)
> (global-set-key (kbd "<C-mouse-5>") 'text-scale-decrease)
> The issue is that linum or nlinum doesn't notice the change, the line
> number gutter doesn'adjust it's width.
Can you test the patch below (for nlinum.el) to see if it solves
your problem?
Stefan
diff --git a/packages/nlinum/nlinum.el b/packages/nlinum/nlinum.el
index 82e274c..ca15800 100644
--- a/packages/nlinum/nlinum.el
+++ b/packages/nlinum/nlinum.el
@@ -1,6 +1,6 @@
;;; nlinum.el --- Show line numbers in the margin -*- lexical-binding: t -*-
-;; Copyright (C) 2012, 2014 Free Software Foundation, Inc.
+;; Copyright (C) 2012, 2014, 2015 Free Software Foundation, Inc.
;; Author: Stefan Monnier <monnier@iro.umontreal.ca>
;; Keywords: convenience
@@ -54,6 +54,7 @@ Linum mode is a buffer-local minor mode."
:lighter nil ;; (" NLinum" nlinum--desc)
(jit-lock-unregister #'nlinum--region)
(remove-hook 'window-configuration-change-hook #'nlinum--setup-window t)
+ (remove-hook 'text-scale-mode #'nlinum--setup-window t)
(remove-hook 'after-change-functions #'nlinum--after-change t)
(kill-local-variable 'nlinum--line-number-cache)
(remove-overlays (point-min) (point-max) 'nlinum t)
@@ -63,6 +64,7 @@ Linum mode is a buffer-local minor mode."
;; FIXME: Another approach would be to make the mode permanent-local,
;; which might indeed be preferable.
(add-hook 'change-major-mode-hook (lambda () (nlinum-mode -1)))
+ (add-hook 'text-scale-mode #'nlinum--setup-window nil t)
(add-hook 'window-configuration-change-hook #'nlinum--setup-window nil t)
(add-hook 'after-change-functions #'nlinum--after-change nil t)
(jit-lock-register #'nlinum--region t))
@@ -71,14 +73,24 @@ Linum mode is a buffer-local minor mode."
(defun nlinum--face-height (face)
(aref (font-info (face-font face)) 2))
+(defun nlinum--face-width (face) ;New info only in Emacs>=25.
+ (let ((fi (font-info (face-font face))))
+ (when (> (length fi) 11)
+ (let ((width (aref info 11)))
+ (if (<= width 0)
+ (aref info 10)
+ width)))))
+
(defun nlinum--setup-window ()
(let ((width (if (display-graphic-p)
(ceiling
- ;; We'd really want to check the widths rather than the
- ;; heights, but it's a start.
- (/ (* nlinum--width 1.0
- (nlinum--face-height 'linum))
- (frame-char-height)))
+ (let ((width (nlinum--face-width 'linum)))
+ (if width
+ (/ (* nlinum--width 1.0 width)
+ (frame-char-width))
+ (/ (* nlinum--width 1.0
+ (nlinum--face-height 'linum))
+ (frame-char-height)))))
nlinum--width)))
(set-window-margins nil (if nlinum-mode width)
(cdr (window-margins)))))