Re: [Gzz-commits] journals mudyc tjl

[Matti Katila]

On Sat, 2 Aug 2003, Tuomas J. Lukka wrote:
> CVSROOT:      /cvsroot/fenfire
> Module name:  journals
> Branch:       
> Changes by:   Tuomas J. Lukka <address@hidden>        03/08/02 04:18:21
> 
> Modified files:
>       .              : mudyc tjl 
> 
> Log message:
>       more
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/journals/mudyc.diff?tr1=1.89&tr2=1.90&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/fenfire/journals/tjl.diff?tr1=1.115&tr2=1.116&r1=text&r2=text
> 
> Patches:
> Index: journals/mudyc
> diff -u journals/mudyc:1.89 journals/mudyc:1.90
> --- journals/mudyc:1.89       Thu Jul 31 10:15:49 2003
> +++ journals/mudyc    Sat Aug  2 04:18:21 2003
> +
> +ASAP:
> +    - [tjl] PEG the controller stuff - it sounds like a really good idea, 
> but 
> +      it needs a real spec and documentation.

What is a good idea? 

> +      several small issues:
> +     - it's mouse code, not controller code, thus name should contain "Mouse"
> +     - it should be in libvob, not fenfire

ok

> +     - you should start by documenting what it needs to do, then deriving
> +       the interfaces from that

The self-explaining interface is:

    /** Two change methods:
     * - change(float x, float y) for delta change.
     * - controlPoint(float x, float y, float scale).
     * The 'change' is aimed for adjusting zoom etc. 
     * which needs change to some direction.
     * On the other hand 'controlPoint' is for mouse cursor 
     * point. With it can be mouse clicks handed.
     *
     * To ask from action which one of the two method is used
     * the method 'isChangeable' is called.
     */
    public interface Controller {
        boolean isChangeable();
        
        /** If controller action can be made without 
         * creating a new VobScene this should return true.
         */
        boolean tryFast();
        void change(float x, float y);
        void controlPoint(float x, float y, float scale);
        
        /** When ControlBinding's 
         * handleEvent is called the 'forObject' and 'oldVS' 
         * are given with set method.
         */
        void set(Object obj, VobScene oldVS);
    }

Hmm.. Controller is more like an action.


> +     - needs documentation

What needs documentation?

> +     - can it allow, e.g. several different drags based on what
> +       object was clicked, i.e. who can route drags to the object
> +       that was clicked and how?

see org/fenfire/view/buoy/actions.py:: 
class ControlsDispatcher(ff.util.ControlBinding):



> -2003-08-01:
> -    - [mudyc] in libvob/include/vob/jni/Types.hxx
> -      how?
> -      START_VOB_JNI_CONVERSION(float *, "float []", jfloatArray) 
> -          out = env->GetFloatArrayElements(in, 0);
> -      END_VOB_JNI_CONVERSION

This still doesn't work. Could you look for it?



   -Matti