guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#73918] [PATCH] gnu: yosys: Update to 0.46.


From: Denis 'GNUtoo' Carikli
Subject: [bug#73918] [PATCH] gnu: yosys: Update to 0.46.
Date: Sat, 26 Oct 2024 18:56:53 +0200

Hi,

Thanks a lot for the patches. 

Note that I'm not a Guix committer nor maintainer.

Also I'm not familiar with best practice for commit messages within the
Guix projects but other projects that care a lot about code quality
tend to indicate the commit that broke something in the commit message.

For instance in Linux we have commits like that:
> This was broken by commit 16aac5ad1fa9 ("ovl: support encoding
> non-decodable file handles"), which didn't take the lower-only
> configuration into account.

That would simplify the review as here a reviewer will probably need to
look into what broke yosys to verify if your fix is the best possible
fix (it probably is).

Denis.

Attachment: pgpJt6Ed715Tm.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]