guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#71254] [PATCH] services: oci-container: fix provided image is strin


From: Fabio Natali
Subject: [bug#71254] [PATCH] services: oci-container: fix provided image is string.
Date: Fri, 31 May 2024 15:14:27 +0100

Hi Zheng,

Thanks for your patch!

For what it's worth, this is to confirm that the patch works for
me. Without the patch, I don't seem to be able to use
'oci-container-service-type', at least when the image is provided as a
string.

I can't comment on the stylistic consistency of the patch (i.e. the use
of '(when #$ ...)' vs '#$@(if ...)'), but it's a +1 for me in terms of
its effectiveness.

Just my 2 cents for other fellow reviewers and the final committer.

Best, Fabio.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]