[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#70818] [PATCH] maint: Suggest ‘guix git authenticate’ for initial a
|
From: |
Maxim Cournoyer |
|
Subject: |
[bug#70818] [PATCH] maint: Suggest ‘guix git authenticate’ for initial authentication. |
|
Date: |
Wed, 22 May 2024 20:55:16 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi!
Ludovic Courtès <ludo@gnu.org> writes:
> The previous recommendation, running ‘make authenticate’, was insecure
> because it led users to run code from the very repository they want to
> authenticate:
>
> https://lists.gnu.org/archive/html/guix-devel/2024-04/msg00252.html
>
> * Makefile.am (commit_v1_0_0, channel_intro_commit)
> (channel_intro_signer, GUIX_GIT_KEYRING, authenticate): Remove.
> * Makefile.am (.git/hooks/%): New target, generalization of previous
> ‘.git/hooks/pre-push’ target.
> (nodist_noinst_DATA): Add ‘.git/hooks/post-merge’.
> * doc/contributing.texi (Building from Git): Suggest ‘guix git
> authenticate’ instead of ‘make authenticate’.
> * etc/git/post-merge: New file.
> * etc/git/pre-push: Run ‘guix git authenticate’ instead of ‘make
> authenticate’.
>
> Reported-by: Skyler Ferris <skyvine@protonmail.com>
> Change-Id: Ia415aa8375013d0dd095e891116f6ce841d93efd
Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
(taking into account the typo spotted by Florian).
Thank you for addressing this!
--
Thanks,
Maxim