[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#71038] [PATCH 1/2] guix: store: Enable specifying the available bui
From: |
Simon Tournier |
Subject: |
[bug#71038] [PATCH 1/2] guix: store: Enable specifying the available builtin builders. |
Date: |
Wed, 22 May 2024 12:58:12 +0200 |
Hi Chris,
On sam., 18 mai 2024 at 14:19, Christopher Baines <mail@cbaines.net> wrote:
> diff --git a/guix/store.scm b/guix/store.scm
> index 58ddaa8d15..0c734cdca7 100644
> --- a/guix/store.scm
> +++ b/guix/store.scm
> @@ -571,7 +571,7 @@ (define* (connect-to-daemon uri #:key non-blocking?)
>
> (define* (open-connection #:optional (uri (%daemon-socket-uri))
> #:key port (reserve-space? #t) cpu-affinity
> - non-blocking?)
> + non-blocking? assume-available-builtin-builders)
Why add the variable %assume-available-builtin-builders and default to
it?
Something like:
--8<---------------cut here---------------start------------->8---
(define %assume-available-builtin-builders
"List of builtin builders supported by the builder Guix daemon."
(list "download" "git-download"))
(define* (open-connection #:optional (uri (%daemon-socket-uri))
#:key port (reserve-space? #t) cpu-affinity
non-blocking?)
non-blocking?
(assume-available-builtin-builders
%assume-available-builtin-builders))
--8<---------------cut here---------------end--------------->8---
And then default to this %assume-available-builtin-builders elsewhere in
[PATCH 2/2]. IMHO, it changes almost nothing but it would help to know
(document) what to pass as argument.
Cheers,
simon