[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' var
From: |
Ludovic Courtès |
Subject: |
[bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. |
Date: |
Sun, 19 May 2024 16:16:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> The Guix standard configuration uses a localstatedir of /var and a sysconfdir
> of /etc. To ease things for everyone, make the default values match that
> standard expected configuration. See
> <https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for a
> related discussion.
>
> * configure.ac: Default $prefix to '' unless already set.
> * doc/contributing.texi (Building from Git): Streamline doc.
> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise.
>
> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212
[...]
> +dnl Set some sane default directory variables for use with the Guix. This
> +dnl also causes localstatedir to be /var and sysconfdir to be /etc.
> +test "$prefix" = NONE && prefix=
Shouldn’t it read “prefix=/”?
Might be good to check whether this breaks “make distcheck”, so I
suppose it should be fine.
Apart from that it LGTM. Thanks for this patch!
Ludo’.