[bug#70570] [PATCH 1/2] guix: import: pypi: Ignore pypi-ignored-inputs.

[Nicolas Graves]

On 2024-04-26 10:26, Lars-Dominik Braun wrote:

> Hi,
>
>> +(define pypi-ignored-inputs
>> +  ;; This list contains packages that are useful for development or quality
>> +  ;; testing, but that most of the time are not necessary to have as an 
>> input.
>> +  (list "argparse"  ; native
>> +        "codecov" "coverage"  ; coverage
>> +        "black" "isort" "pycodestyle" "pep8"  ; style
>> +        "pyflakes" "flake8" "pylint" "mypy"  ; style+lint
>> +        "coveralls" "twine"  ; upload integration tools
>> +        "pytest-isort" "pytest-flake8" "pytest-cov" "pytest-black"
>> +        "pytest-pep8" "pytest-mypy" "pytest-pep8" "pre-commit"))  ; variants
>
>> +  (let ((input-names (append
>> +                      '("python-setuptools"
>> +                        "python-pip"
>> +                        "python-pre-commit")
>> +                      pypi-ignored-inputs)))
>
> we should remove python-setuptools from this list now (since it actually
> should be an input on the python-team branch), python-pre-commit is
> also part of pypi-ignored-inputs and maybe we can just add pip to
> pypi-ignored-inputs and use only that list?

Yes, but then it should be done in an independent commit IMO to keep
this one focused on native-inputs and pytest, and then add one for your
other changes of the build system.

But yes, I think they ought to be in the same list.

>
> Also note that check-inputs-should-not-be-an-input-at-all expects Guix
> package names (with python- prefix), whereas pypi-ignored-inputs uses
> Python package names, so you probably want to (map (cut (string-append
> "python-" <>) …) (or similar) here.

Perfectly right, thanks for noticing.

About pre-commit : if we add the python- prefix, then we use the
outdated variable. Maybe we should remove if pypi-ignored-inputs here,
and add "pre-commit" idependently.


> Lars
>

Another quick note : The plugin could also be several plugins (one per
package) in the store added in the PYTHONPATH, which would enable us to
not regenerate the file everytime, but it doesn't compile with (guix
gexp) module. It might be more efficient / guixy this way, but I'm not
able to do it.

If you know how to, don't hesitate ;)

-- 
Best regards,
Nicolas Graves