[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#67898] [PATCH v2] guix: import: composer: Handle parsing failures.
From: |
Nicolas Graves |
Subject: |
[bug#67898] [PATCH v2] guix: import: composer: Handle parsing failures. |
Date: |
Sat, 06 Apr 2024 02:55:08 +0200 |
On 2024-04-05 22:09, Ludovic Courtès wrote:
>> + (match composer-package
>> + (#f
>> + (format (current-error-port)
>> + "warning: failed to parse ~a~%"
>> + php-name)
>
> Does #f necessarily indicate a parse error? Couldn’t we have more
> detailed info about the error? (Not a blocker but it would be nice.)
>
Well if go through the changes, it could fail on each step of the let*,
so we could indeed be more precise, though it eventually comes down to
a fetch or parsing error. Will fix this in a later patch.
Actually I'm probably going to merge the different patches in a single
patch series, that would make it more convenient to review on your side.
>> + #f)
>> + (_
>> + (upstream-source
>
> Nitpick: I’d suggest using a plain ‘if’ rather than ‘match’ in this case
> since it’s a binary choice without destructuring.
>
> Could you send an updated patch?
>
> Thanks,
> Ludo’.
--
Best regards,
Nicolas Graves