guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#69355] [PATCH] gnu: Add libgrapheme.


From: cage
Subject: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Tue, 2 Apr 2024 18:36:40 +0200

On Sun, Mar 31, 2024 at 09:26:25PM -0400, Maxim Cournoyer wrote:
> Hi cage,

Hi!

> cage <cage-dev@twistfold.it> writes:
>
> [...]
>
> > ---
> >  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> > index 81e2151854..b89b3be961 100644
>
>
> I've added a simple commit message, as autogenerated with 'add...TAB' in
> the commit message buffer in Emacs using yasnippet (you could have also
> used 'etc/committer.scm').

Thanks  for  your suggestion,  i  tried  using  yasnippet but  with  no
luck. :( But i will try again at the next patch, i swear! :D

[...]

> Note the lack of a period for the synopsis (it is not a
> complete sentence -- I think 'guix lint' would have spotted that).

Yes, likely i did not run guix line, this time, sorry! ^^;

[...]
> I've dropped 'extremely' which sounded like marketing, and pushed.

I agree it is inappropriate here.

> Thanks for your contribution!

Thanks to you for fixing the patch!
C.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]