[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12.
From: |
Skyler Ferris |
Subject: |
[bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12. |
Date: |
Sat, 30 Mar 2024 14:35:06 +0000 |
On 3/28/24 22:18, Philip McGrath wrote:
> +(define chez-configure
> + ;; The custom Chez 'configure' script doesn't allow unrecognized flags,
> such
> + ;; as those automatically added by `gnu-build-system`. This replacement
> + ;; phase uses only the explicitly provided `#:configure-flags`.
> + #~(lambda* (#:key inputs (configure-flags '()) out-of-source?
> + #:allow-other-keys)
> + (let* ((abs-srcdir (getcwd))
> + (srcdir (if out-of-source?
> + (string-append "../" (basename abs-srcdir))
> + ".")))
> + (format #t "source directory: ~s (relative from build: ~s)~%"
> + abs-srcdir srcdir)
> + (when out-of-source?
> + (begin
> + (mkdir "../build")
> + (chdir "../build")))
> + (format #t "build directory: ~s~%" (getcwd))
> + (format #t "configure flags: ~s~%" configure-flags)
> + (apply invoke
> + (string-append srcdir "/configure")
> + configure-flags))))
> +
Are the format statements supposed to be here or are they left over from
debugging?
> + ;; Building the documentation requires stex and a running scheme.
> + ;; TODO: improve cross support upstream.
I believe this comment should be associated with the build-docs phase,
not the install-docs phase, correct?
Additionally, I am not too familiar with autotools, so while I did look
over it and the changes seem reasonable my perspective on that aspect of
this patch should be taken with a grain of salt.
- [bug#70065] [PATCH 0/6] gnu: Update to Racket 8.12, Chez Scheme 10, and Zuo 1.9., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 2/6] gnu: racket: Update to 8.12.,
Skyler Ferris <=
- [bug#70065] [PATCH 1/6] gnu: zuo: Update to 1.9., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 6/6] gnu: chez-scheme: Bootstrap from source., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 3/6] gnu: chez-scheme: Reorganize package definitions., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 5/6] gnu: chez-scheme: Update and simplify machine-type handling., Philip McGrath, 2024/03/29
- [bug#70065] [PATCH 4/6] gnu: chez-scheme: Update to 10.0.0., Philip McGrath, 2024/03/29