[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69783] [PATCH]: website: Convert old style sheets into a theme
From: |
pelzflorian (Florian Pelz) |
Subject: |
[bug#69783] [PATCH]: website: Convert old style sheets into a theme |
Date: |
Fri, 15 Mar 2024 11:19:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Luis Felipe <sirgazil@zoho.com> writes:
> Hi Florian, thank you very much for reviewing.
>
> El 14/03/24 a las 16:56, pelzflorian (Florian Pelz) escribió:
>> the patch looks good, although I will not push it as I do not know where
>> the CSS file for manuals is set (guix repo? maintenance?). And,
>
> It seems the stylesheets for the manuals are set in
> https://git.savannah.gnu.org/cgit/guix.git/tree/doc/build.scm.
Thank you, yes. Someone with access to maintenance / berlin might have
to kickstart the manual build, which is another reason I was hesitant to
push. I can push later today and the worst that can happen is that CSS
will be missing for those who do not have cached the CSS file.
>> * themes is a name clash with haunt themes
>> <https://files.dthompson.us/docs/haunt/latest/Blog.html#index-theme>,
>> which may be OK nonetheless. But theme could also be named style or
>> something. Or not. The name themes is quite fitting.
>
> Yeah, personally, I don't mind using the |themes| concept for both the
> SXML components and the CSS stylesheets because of their relation. But
> I wouldn't mind using |styles| if necessary. So, if you prefer the
> latter, let me know and I'll update the patch.
>
No, I believe the name clash is okay, because themes is such a fitting
name.
>> * I wonder, why are static/base/img/icon and scientific-mark.svg created
>> and not moved?
> Right, they are leftovers. I can provide an updated patch to fix that.
Thank you for confirming they are the same.
Regards,
Florian