guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#69581] [PATCH 03/11] guix: cpu: Be consistent with x86_64 micro-arc


From: Efraim Flashner
Subject: [bug#69581] [PATCH 03/11] guix: cpu: Be consistent with x86_64 micro-architecture names.
Date: Thu, 7 Mar 2024 11:11:49 +0200

On Wed, Mar 06, 2024 at 06:53:24PM +0100, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > * gnu/packages/golang.scm (%go-1.18-x86_64-micro-architectures): Rename
> > micro-architectures from x86_64-v* to x86-64-v*.
> > * guix/cpu.scm (cpu->gcc-architecture): Return x86-64 as the fallback.
> > (cpu->micro-architecture-level): Rename micro-architectures from
> > x86_64-v* to x86-64-v*.
> > (gcc-architecture->micro-architecture-level): Same.
> >
> > Change-Id: I37db65970417c22699ae8097b0361bccf76c1267
> 
> LGTM.
> 
> Do I get it right that with the previous names, those procedures were
> incorrect, because the underscore names are not recognized by GCC?
> 
> BTW, you can drop “guix:” from the first line of the commit log.

All our compilers expect a dash instead of an underscore, except for go
which doesn't care since we only need the v[234].

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]