[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures.
From: |
Christopher Baines |
Subject: |
[bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures. |
Date: |
Mon, 26 Feb 2024 11:03:04 +0000 |
User-agent: |
mu4e 1.10.8; emacs 29.1 |
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> These names should be more descriptive.
>>
>> * guix/store/database.scm (path-id): Rename to select-valid-path-id.
>> (sqlite-register): Rename to register-valid-path.
>> (register-items): Update accordingly.
>>
>> Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db
>
> OK for ‘register-valid-path’.
>
> For ‘path-id’ my preference would be ‘valid-path-id’ or keeping
> ‘path-id’; ‘select’ looks odd as nothing’s being “selected” here in the
> non-SQL sense of the word.
The main thing I'm trying to do here is make the procedures that
directly interact with the database stand out (similar to the ! suffix
convention). Maybe the procedure taking the db as an argument is enough,
but to me path-id/valid-path-id look too much like record accessors.
signature.asc
Description: PGP signature
[bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures., Christopher Baines, 2024/02/20
[bug#69292] [PATCH 3/6] store: database: Inline SQL to where it's used., Christopher Baines, 2024/02/20
[bug#69292] [PATCH 1/6] store: database: Remove call-with-savepoint and associated code., Ludovic Courtès, 2024/02/23