[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeou
|
From: |
Ludovic Courtès |
|
Subject: |
[bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeout in download-nar. |
|
Date: |
Fri, 23 Feb 2024 17:19:46 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Christopher Baines <mail@cbaines.net> skribis:
> I don't think the approach of using SIGALARM here for the timeout will work
> well in all cases (e.g. when using Guile Fibers), so make it possible to avoid
> this.
>
> * guix/scripts/substitute.scm (download-nar): Pass the fetch timeout in as an
> option.
>
> Change-Id: I8cbe6cdfa10cdaa7d41974cbea56a95f5efecfe6
The patch LGTM.
That said, maybe we should just pass #:timeout to ‘http-fetch’? It’s
not strictly equivalent because it only controls the timeout on
connection establishment, but in practice it should have the same
effect.
Ludo’.
- [bug#69291] [PATCH 0/5] Start making substitute code less coupled, Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 1/5] scripts: substitute: Remove side effect warning from network-error?., Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 3/5] scripts: substitute: Replace some leave calls with raise., Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeout in download-nar., Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeout in download-nar.,
Ludovic Courtès <=
- [bug#69291] [PATCH 5/5] scripts: substitute: Extract script specific output from download-nar., Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 4/5] scripts: substitute: Untangle selecting fast vs small compressions., Christopher Baines, 2024/02/20
- [bug#69291] [PATCH 1/5] scripts: substitute: Remove side effect warning from network-error?., Ludovic Courtès, 2024/02/23