[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#62375] [PATCH 0/1] npm binary importer
From: |
Nicolas Graves |
Subject: |
[bug#62375] [PATCH 0/1] npm binary importer |
Date: |
Thu, 08 Feb 2024 01:59:16 +0100 |
On 2023-03-22 12:25, jlicht@fsfe.org wrote:
> From: Jelle Licht <jlicht@fsfe.org>
>
> Folks,
>
> Here a revised patch to add the npm binary importer. To give some context,
> 'binary' here refers to the fact that this downloads archives straight from
> the npm registry at https://registry.npmjs.org. Some of these downloaded
> archives may not contain the original sources, so unless properly vetted the
> output of this importer does not allow one to easily generate package
> expressions for inclusion in guix's collection of packages.
>
> It should work as-is for most simple NPM packages. As noted in an inline
> comment somewhere, the way both npm and our very own node-build-system treats
> peer dependencies may require some manual intervention from time to time to
> hook in the right dependency at the right spot. The upside here is that when
> this happens, it's either trivial for a human to spot and fix, or wholly
> incompatible with our current approach so not fixable without writing a custom
> build system to deal with dependency cycles :-).
>
> Please test and review, let us get this merged as it might be useful to many
> people for building out their personal channels and/or package expressions.
>
> Special thanks to Timothy Sample and Lars-Dominik Braun for involvement in
> realising this, way too long ago.
>
>
> Jelle Licht (1):
> import: Add binary npm importer.
>
> Makefile.am | 2 +
> guix/import/npm-binary.scm | 269 +++++++++++++++++++++++++++++
> guix/scripts/import.scm | 2 +-
> guix/scripts/import/npm-binary.scm | 113 ++++++++++++
> 4 files changed, 385 insertions(+), 1 deletion(-)
> create mode 100644 guix/import/npm-binary.scm
> create mode 100644 guix/scripts/import/npm-binary.scm
Hey Jelle,
Just to understand, is there a reason why you didn't went further with
the sucrase approach?
--
Best regards,
Nicolas Graves
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#62375] [PATCH 0/1] npm binary importer,
Nicolas Graves <=