[bug#68641] [PATCH 17/19] gnu: libpasastro: Use G-Expressions.

[Sharlatan Hellseher]

Hi Efraim,

Thank you for the review and feedback!

> This package compiles just fine for riscv64 so there's no reason to
> limit it to only certain architectures.

That's is a great new, I did not try to build it on any other OS or
platform. The reason I've add that flags is not a standard Makfile
coming with the project.

https://github.com/pchev/libpasastro/blob/master/Makefile

--8<---------------cut here---------------start------------->8---
all:
ifeq ($(OS_TARGET),win32)
        $(MAKE) -C getdss -f Makefile.win32 all
        $(MAKE) -C plan404 -f Makefile.win32 all
        $(MAKE) -C wcs -f Makefile.win32 all
 else
 ifeq ($(OS_TARGET),win64)
        $(MAKE) -C getdss -f Makefile.win64 all
        $(MAKE) -C plan404 -f Makefile.win64 all
        $(MAKE) -C wcs -f Makefile.win64 all
 else
 ifeq ($(CPU_TARGET),i386)
        $(MAKE) -C getdss all arch_flags=-m32
        $(MAKE) -C plan404 all arch_flags=-m32
        $(MAKE) -C wcs all arch_flags=-m32
 else
 ifeq ($(CPU_TARGET),x86_64)
        $(MAKE) -C getdss all arch_flags=-m64
        $(MAKE) -C plan404 all arch_flags=-m64
        $(MAKE) -C wcs all arch_flags=-m64
 else
        $(MAKE) -C getdss all
        $(MAKE) -C plan404 all
        $(MAKE) -C wcs all
 endif
 endif
 endif
endif

clean:
ifeq ($(OS_TARGET),win32)
        $(MAKE) -C getdss -f Makefile.win32 clean
        $(MAKE) -C plan404 -f Makefile.win32 clean
        $(MAKE) -C wcs -f Makefile.win32 clean
else
ifeq ($(OS_TARGET),win64)
        $(MAKE) -C getdss -f Makefile.win64 clean
        $(MAKE) -C plan404 -f Makefile.win64 clean
        $(MAKE) -C wcs -f Makefile.win64 clean
else
        $(MAKE) -C getdss clean
        $(MAKE) -C plan404 clean
        $(MAKE) -C wcs clean
endif
endif

ifeq ($(OS_TARGET),darwin)
install:
        ./install_darwin.sh $(PREFIX)
else
install:
        ./install.sh $(PREFIX) $(CPU_TARGET)
install_win:
        ./install_win.sh win32 $(PREFIX)
install_win64:
        ./install_win.sh win64 $(PREFIX)
endif
--8<---------------cut here---------------end--------------->8---

> (%current-target-system) returns i686-linux-gnu for the first one, so
> it'd probably be better to use cond and (target-x86-32?) for the first
> one.
>
> I'm not actually convinced you need any of the flags for OS_TARGET or
> CPU_TARGET (except perhaps for cross-compiling), does it make a
> difference between compiled with or without?

I would dedicate some time to figure out how to satisfy custom Makefile
to be compatible for larger range of systems available in Guix. Putting
to my TODO for 2024/02 updates.

Regards,
Oleg

signature.asc
Description: PGP signature