guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#66094]


From: Sharlatan Hellseher
Subject: [bug#66094]
Date: Sun, 19 Nov 2023 19:46:23 +0000

Hi,

Thank you for the patch.

It contains quite a long list of modifications and makes the review harder to follow. 
May you split the patch into logical sub patches, please. It may help to rework QA warnings more explicit.

Some recommendations of grouping:
- update only version and hash, add missing input to complete the build
- any cosmetic changes, like update synopsis, description, homepage 
- change in build system and fixing related issues 
- extend build in arguments, which adds new outputs
- enabling/disabling tests

Thanks,
Oleg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]