guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#66823] [PATCH gnome-team v4 3/6] gnu: Add sofia-sip.


From: Maxim Cournoyer
Subject: [bug#66823] [PATCH gnome-team v4 3/6] gnu: Add sofia-sip.
Date: Tue, 31 Oct 2023 23:09:49 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Hi Vivien:

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/telephony.scm (sofia-sip): New variable.

[...]

> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-shebangs
> +            (lambda _
> +              (patch-shebang "autogen.sh")))
> +          (add-after 'unpack 'disable-failing-test
> +            (lambda _
> +              ;; The test failures have been reported:
> +              ;; https://github.com/freeswitch/sofia-sip/issues/234:
> +              ;; run_test_nta is disabled because it fails randomly (not for 
> a
> +              ;; timeout-related reason).  The test suite is otherwise very
> +              ;; long, most tests backed by libcheck timeout even with a ×100
> +              ;; multiplier.  The tests are disabled here rather than put to
> +              ;; XFAIL_TESTS because it saves compilation time.

nitpick: I typically use the "Explanatory comment (see: $url)." scheme
taught to be by Ludovic as in this case URL is unambiguous (never
includes a trailing '.' for example).

Thanks for reporting the issues!

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]