[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66160] [PATCH] gnu: Add oci-container-service-type.
From: |
Ludovic Courtès |
Subject: |
[bug#66160] [PATCH] gnu: Add oci-container-service-type. |
Date: |
Tue, 24 Oct 2023 17:41:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi,
paul <goodoldpaul@autistici.org> skribis:
[...]
>> In that case, maybe create an “oci-service” account part of the “docker”
>> group, and run ‘docker run’ as that user instead of running it as root?
>> Would that be OK or am I overlooking something?
> I already added such user in the latest version of my patch. I
> probably made a mess with patch subjects.
Oh, my bad; perfect then.
>> What I’m suggesting above is that one would build a list of
>> ‘oci-container-service-type’ instances, like:
>>
>> (list (service oci-container-service-type
>> (oci-container-configuration …))
>> (service oci-container-service-type
>> (oci-container-configuration …))
>> …)
>>
>> Each instance above would correspond to exactly one program in a Docker
>> image.
>>
>> I feel it’s slightly more natural than having a service type that
>> implements support for multiple OCI services at once.
> I agree it's more natural but (list service-a service-b ...) it's the
> same interface exposed by the shepherd-root-service-type, I believe
> for the same reasons I need the oci-nextcloud-service-type to
> instantiate 3 shepherd services but only create a single account,
> activate a single data dir under /var/lib, something like this:
>
> (defineoci-nextcloud-service-type
> (service-type(name'nextcloud)
> (extensions(list(service-extensionoci-container-service-type
> (lambda (config) (make-nextcloud-container config)
> (make-nextcloud-cron-container config)))
[...]
> The only way where oci-container-service-type could support this use
> case by accepting a single configuration is I guess if multiple
> (service-extension oci-container-service-type ...) where allowed, am I
> understanding correctly? Is it legal in Guix to write somthing like:
>
> (extensions(list(service-extensionoci-container-service-type
> make-nextcloud-container)
> (service-extensionoci-container-service-typemake-nextcloud-cron-container)
> (service-extensionaccount-service-type
> (const%nextcloud-accounts))
> (service-extensionactivation-service-type
> %nextcloud-activation)))
If you take the route of one ‘oci-container-service-type’ per
daemon/server that you want to run, then <oci-container-configuration>
should probably have a ‘user’ field to specify under which user to run
the container. ‘oci-container-service-type’ would create exactly one
Shepherd service so, likewise, <oci-container-configuration> would need
a ‘provision’ field to specify the Shepherd service name (the
“provisions”). Likewise, perhaps a field to specify the data directory
is needed.
Does that make sense?
Thanks,
Ludo’.
[bug#66160] [PATCH] gnu: Add oci-container-service-type., Giacomo Leidi, 2023/10/13
[bug#66160] [PATCH] gnu: Add oci-container-service-type., Giacomo Leidi, 2023/10/14
[bug#66160] [PATCH] gnu: Add oci-container-service-type., Giacomo Leidi, 2023/10/14