[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65866] [PATCH v2 1/8] git-download: Move fallback code to (guix bui
From: |
Simon Tournier |
Subject: |
[bug#65866] [PATCH v2 1/8] git-download: Move fallback code to (guix build git). |
Date: |
Mon, 25 Sep 2023 10:15:21 +0200 |
Hi Ludo,
On Sat, 23 Sep 2023 at 00:27, Ludovic Courtès <ludo@gnu.org> wrote:
> + ;; XXX: Currently recursive checkouts are not supported.
> + (and (not recursive?)
Naively, and similarly as Maxim’s remark, maybe we could raise a warning
when the case is not supported instead of silently return #f.
If raising a warning here is not appropriate, maybe document in the
docstring the returned value as #f.
> - (with-extensions (list guile-json gnutls ;for (guix swh)
> + (with-extensions (list guile-json gnutls ;for (guix swh)
Nitpick: Since the change is complex, I would suggest to avoid this
cosmetic.
Cheers,
simon
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/11
- [bug#65866] [PATCH 4/8] daemon: Add “git-download” built-in builder., Ludovic Courtès, 2023/09/11
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Maxim Cournoyer, 2023/09/20
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/21
- [bug#65866] [PATCH v2 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 1/8] git-download: Move fallback code to (guix build git)., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 1/8] git-download: Move fallback code to (guix build git).,
Simon Tournier <=
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/25
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Simon Tournier, 2023/09/25
- [bug#65866] [PATCH v2 3/8] perform-download: Remove unused one-argument clause., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 2/8] git-download: Honor the ‘GUIX_DOWNLOAD_FALLBACK_TEST’ environment variable., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 8/8] tests: Assume ‘git’ is always available., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 6/8] perform-download: Use the ‘git’ command captured at configure time., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 4/8] daemon: Add “git-download” built-in builder., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 7/8] git-download: Use “builtin:git-download” when available., Ludovic Courtès, 2023/09/22
- [bug#65866] [PATCH v2 7/8] git-download: Use “builtin:git-download” when available., Simon Tournier, 2023/09/25
- [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts, Ludovic Courtès, 2023/09/25