guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#64933] [PATCH] gnu: Add dexy-color-sddm-theme.


From: Ludovic Courtès
Subject: [bug#64933] [PATCH] gnu: Add dexy-color-sddm-theme.
Date: Sun, 17 Sep 2023 15:13:54 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi,

And apologies for the late reply.

Sergio Pastor Pérez <sergio.pastorperez@outlook.es> skribis:

> * gnu/packages/display-managers.scm (dexy-color-sddm-theme): New variable.

[...]

> +      (build-system trivial-build-system)
> +      (arguments
> +       `(#:modules ((guix build utils))
> +         #:builder (begin
> +                     (use-modules (guix build utils))
> +                     (let* ((out (assoc-ref %outputs "out"))
> +                            (sddm-themes (string-append out
> +                                                        
> "/share/sddm/themes")))
> +                       (mkdir-p sddm-themes)
> +                       (copy-recursively (string-append (assoc-ref
> +                                                         %build-inputs
> +                                                         "source")
> +                                                        "/Dexy-Color-SDDM")
> +                                         (string-append sddm-themes
> +                                                        "/dexy-color"))))))

Could you consider writing it using ‘copy-build-system’?  It should lead
to a more concise definition.

> +      (home-page "https://github.com/L4ki/Dexy-Plasma-Themes";)
> +      (synopsis "Dexy Color theme for SDDM")
> +      (description "Dexy-Color-SDDM is part of KDE Themes and Extensions.")

It would be great if you could add a sentence saying what the package
provides (think about someone running ‘guix search’ and not knowing
which package might provide the thing).

Could you send an updated patch?

Thanks in advance,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]