[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65717] [PATCH] gnu: Add emacs-latex-extra.
From: |
Nicolas Goaziou |
Subject: |
[bug#65717] [PATCH] gnu: Add emacs-latex-extra. |
Date: |
Sun, 03 Sep 2023 21:44:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Sergiu Ivanov <sivanov@colimite.fr> writes:
> Subject: [PATCH] gnu: Add emacs-latex-extra.
Thank you.
Some comments follow.
> + (build-system emacs-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'build 'set-home
> + (lambda _
> + (setenv "HOME"
> + (getcwd)))))))
Why is it needed ?
Also, upstream provides tests. Could you run them?
> + (inputs (list emacs-auctex))
Usually, inputs are propagated, although it doesn't make a difference
for Emacs.
> + (home-page "https://github.com/Malabarba/latex-extra")
> + (synopsis "Usability improvements for latex-mode")
Nitpick: "latex-mode" -> "LaTeX mode"
> + (description
> + "Latex-extra defines extra commands and keys for LaTeX-mode, as well
> +as brings user experience improvements.")
Nitpick: "LaTeX-mode" -> "LaTeX mode"
Could you send an updated patch?
Regards,
--
Nicolas Goaziou