guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#64931] [PATCH] guix: pull: Also print the name of the branch.


From: Simon Tournier
Subject: [bug#64931] [PATCH] guix: pull: Also print the name of the branch.
Date: Wed, 16 Aug 2023 18:41:34 +0200

Hi,

On Sat, 29 Jul 2023 at 14:04, Attila Lendvai <attila.lendvai@gmail.com> wrote:

> -                             (G_ "Updating channel '~a' from Git repository 
> at '~a'...~%")
> +                             (G_ "Updating channel '~a' from Git repository 
> at \
> +'~a', branch  '~a'...~%")
>                               (channel-name channel)
> -                             (channel-url channel))
> +                             (channel-url channel)
> +                             (channel-branch channel))

That’s nice but I see a potential confusion when using “guix pull
--commit” or “guix time-machine --commit”.  Well, from ’channel-list’ in
(guix scripts pull), if the option --commit is provided then the branch
is set to #f.  Therefore, it would display “, branch #f...” which could
be misleading.

Somehow, this display should be conditional depending on if
’channel-branch’ is not #f.  WDYT?

Cheers,
simon







reply via email to

[Prev in Thread] Current Thread [Next in Thread]