[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64957] [PATCH vREVISION] gnu: Add python-fontmake.
From: |
Hilton Chain |
Subject: |
[bug#64957] [PATCH vREVISION] gnu: Add python-fontmake. |
Date: |
Mon, 31 Jul 2023 02:06:00 +0800 |
Hi Sergio,
On Sun, 30 Jul 2023 23:45:20 +0800,
Sergio Pastor Pérez wrote:
>
> * gnu/packages/fontutils.scm (python-fontmake): New variable.
> ---
Please adjust the commit message as well.
> + (version "3.4.0")
The latest version is 3.6.1, can you update the definition for it?
> + (build-system python-build-system)
> + (propagated-inputs (list python-attrs
Please change the `propagated-inputs' field into `inputs'.
It's not necessary to propagate those inputs, as python-build-system
already wraps the final fontmake program to find them.
> + (synopsis
> + "Compile fonts from sources (UFO, Glyphs) to binary (OpenType,
> TrueType)")
> + (description
> + "Fontmake compiles fonts from various sources (.glyphs, .ufo,
> designspace) into binaries (.otf, .ttf). You can use it to create static
> instances and variable fonts.")
There are some format issues, which could also be found by running
`./pre-inst-env guix lint fontmake' in your Guix checkout, I have
attatched the output below.
--8<---------------cut here---------------start------------->8---
gnu/packages/fontutils.scm:535:5: fontmake@3.4.0: sentences in description
should be followed by two spaces; possible infraction at 100
gnu/packages/fontutils.scm:535:0: fontmake@3.4.0: line 535 is way too long (171
characters)
gnu/packages/fontutils.scm:531:15: fontmake@3.4.0: permanent redirect from
https://github.com/googlei18n/fontmake to
https://github.com/googlefonts/fontmake
--8<---------------cut here---------------end--------------->8---
And... The REVISION in the `git send-email' part of the manual should
be replaced with a number, for example:
--8<---------------cut here---------------start------------->8---
$ git send-email --annotate -v2 \
--to=ISSUE_NUMBER@debbugs.gnu.org -1
--8<---------------cut here---------------end--------------->8---
It's used in the [PATCH v...] part of the title.
Thanks