[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63402] [PATCH v5 2/5] services: wireguard: Implement a dynamic IP m
From: |
Maxim Cournoyer |
Subject: |
[bug#63402] [PATCH v5 2/5] services: wireguard: Implement a dynamic IP monitoring feature. |
Date: |
Fri, 21 Jul 2023 11:56:08 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
>>>> +(define endpoint-host-names
>>>> + (@@ (gnu services vpn) endpoint-host-names))
>>>> +
>>>> +(test-begin "vpn-services")
>>>> +
>>>> +(test-assert "ipv4-address?"
>>>> + (every ipv4-address?
>>>> + (list "192.95.5.67:1234"
>>>> + "10.0.0.1")))
>>>> +
>>>> +(test-assert "ipv6-address?"
>>>> + (every ipv6-address?
>>>> + (list "[2607:5300:60:6b0::c05f:543]:2468"
>>>> + "2607:5300:60:6b0::c05f:543"
>>>> + "2345:0425:2CA1:0000:0000:0567:5673:23b5"
>>>> + "2345:0425:2CA1::0567:5673:23b5")))
>>>
>>> Are these addresses special?
>>> If not, I'd recommend (properly) generating a random ULA prefix
>>> and use it instead.
>>
>> They are not! I derived them from actual IP addresses, adding some
>> fuzz. I've now used unique local IPv6 prefixes.
>
> Actually since these are only used for testing your predicate procedure
> it might be better to use the 2001:db8::/32 reserved prefix instead if
> I'm interpreting RFC3849 correctly.
Done.
--
Thanks,
Maxim