[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64711] [PATCH 39/43] gnu: harfbuzz: Support build for the Hurd.
From: |
Maxim Cournoyer |
Subject: |
[bug#64711] [PATCH 39/43] gnu: harfbuzz: Support build for the Hurd. |
Date: |
Tue, 18 Jul 2023 16:13:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Janneke Nieuwenhuizen <janneke@gnu.org> writes:
> * gnu/packages/gtk.scm (harfbuzz)[native-inputs]: Do not include
> gobject-introspection when building for the Hurd.
> ---
> gnu/packages/gtk.scm | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index eb69a88221..853696c7f5 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -276,11 +276,13 @@ (define-public harfbuzz
> ;; There are all in the Requires or Requires.private field of '.pc'.
> (list glib graphite2 icu4c))
> (native-inputs
> - (list `(,glib "bin") ;for glib-mkenums
> - gobject-introspection
> - pkg-config
> - python-wrapper
> - which))
> + `((,glib "bin") ;for glib-mkenums
> + ,@(if (target-hurd?)
> + '()
> + (list gobject-introspection))
> + ,pkg-config
> + ,python-wrapper
> + ,which))
Here also (basically when it's touching label-free inputs), I'd use
append with a conditional to avoid the unquote noise.
Otherwise LGTM.
--
Thanks,
Maxim
- [bug#64711] [PATCH 40/43] gnu: pango: Support build for the Hurd., (continued)
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Liliana Marie Prikler, 2023/07/18
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Maxim Cournoyer, 2023/07/18
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/20
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Maxim Cournoyer, 2023/07/20
- [bug#64711] [PATCH 37/43] gnu: glib: Disable tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/21
[bug#64711] [PATCH 41/43] gnu: fontforge: Support build on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 39/43] gnu: harfbuzz: Support build for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
- [bug#64711] [PATCH 39/43] gnu: harfbuzz: Support build for the Hurd.,
Maxim Cournoyer <=
[bug#64711] [PATCH 33/43] gnu: cmake-minimal: Skip tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 34/43] gnu: doxygen: Fix build for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 31/43] gnu: zstd: Skip tests when building for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 32/43] gnu: cmake-bootstrap: Fix build for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 43/43] gnu: guile-2.0: Skip failing tests on the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 00/43] Fix builds and skip failing tests for the Hurd., Janneke Nieuwenhuizen, 2023/07/18
[bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd., Ludovic Courtès, 2023/07/18