[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies
From: |
Ludovic Courtès |
Subject: |
[bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies |
Date: |
Tue, 18 Jul 2023 13:52:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Benjamin <benjamin@uvy.fr> skribis:
> A lot of dependencies were required, but for most of them, this is just
> a dune subpackage.
> For ocaml-dune-build-info, note that I included the patch from [0]
> and I used the same technique for other dune packages.
>
> The latest version of ocaml-lsp-server depends on ocaml-merlin-lib.
> I added a compatible version as a new package instead of upgrading
> current ocaml-merlin-lib as I was not sure if it would be safe to do so.
>
> Finally, the version 1.6.1 is supporting ocaml 5.0 and 5.1 [1] but I only
> tested for 5.0.
> Also, as 4.14 is not compatible with it, I only made public version 5.0
> of it. I do not no either if was the good thing to be done.
>
> I tested lsp server localy and it has been working fine with neovim for
> my usage.
>
> [0] https://issues.guix.gnu.org/63947
> [1] https://github.com/ocaml/ocaml-lsp/blob/master/CHANGES.md#1161
I’m not on the OCaml team, so I’ll let Julien and pukkamustard comment.
One issue: could you work on improving synopses and descriptions a bit
and submit a v2, as per
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>?
Don’t spend hours on this, but at least try to have sentences with a
bit of context in ‘description’.
Thanks in advance!
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies,
Ludovic Courtès <=