|
From: | Andy Tai |
Subject: | [bug#64261] [PATCH] gnu: Add xrdp |
Date: | Tue, 11 Jul 2023 07:13:18 -0700 |
Hi Andy,
Andy Tai <atai@atai.org> skribis:
> * gnu/packages/rdesktop.scm (xrdp): New variabble
> (xorgxrdp): New variable
Could you send a v2 with one patch per package, as is customary?
> + (home-page "https://www.xrdp.org")
> + (synopsis "Open source RDP server ")
Please remote the trailing slash as well as “open source”: everything is
free software in here, so no need to specify it! :-) However, please
spell out “Remote Desktop Protocol (RDP)”.
> + (description
> + "Xrdp provides a graphical login to remote machines using
> +Microsoft Remote Desktop Protocol (RDP). Xrdp accepts connections from a
> +variety of RDP clients:
> +* FreeRDP
> +* rdesktop
Please use @itemize.
See
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>.
> +(define-public xorgxrdp
> + (package
> + (name "xorgxrdp")
> + (version "0.9.19")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/neutrinolabs/xorgxrdp/releases/download/v"
> + version "/xorgxrdp-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0m8lvdnhfvwwqrr56difgy3mblplp23x6iy12kl4r8i87ic4rky1"))))
Should it inherit from ‘xrdp’? I fail to see what the difference is.
> + (arguments
> + (list #:configure-flags #~(list "--enable-strict-locations=yes"
> + (string-append "XRDP_CFLAGS=-I"
> + (assoc-ref %build-inputs
> + "xrdp")
> + "/common"))))
Rather than (assoc-ref …), write #$(this-package-input "xrdp').
Also, xrdp should not have .h files under /common; it should be under
/include or /include/common or similar. Could you check that?
> + (home-page "https://github.com/neutrinolabs/xorgxrdp")
> + (synopsis "Xorg drivers for xrdp")
> + (description
> + "xorgxrdp is a collection of modules to be used with a pre-existing X.Org
> +install to make the X server act like X11rdp")
Please add a period at the end of the sentence and expound a bit so one
can better understand what this is about.
Thanks in advance!
Ludo’.
[Prev in Thread] | Current Thread | [Next in Thread] |