bug#63729: [PATCH] gnu: Add greaseweazle-host-tools.

[Nicolas Goaziou]

Hello,

Rikard Nordgren <hrn@posteo.net> writes:

> ---
>  gnu/packages/disk.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

Applied with a proper commit message and changes described below. Thank you.

> +(define-public greaseweazle-host-tools
> +  (package
> +    (name "greaseweazle-host-tools")
> +    (version "1.12")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/keirf/greaseweazle";)
> +                    (commit "v1.12")))

I re-used the version here:

  (commit (string-append "v" version))

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases

I used G-expressions:

  (arguments (list #:phases #~(modify-phases ...)))

> +                  (add-before 'build 'setuptools-version
> +                    (lambda _
> +                      (setenv "SETUPTOOLS_SCM_PRETEND_VERSION" "1.8") #t))

No need for trailing #T at the end of phases; il removed it.

> +                  (add-after 'install 'install-udev-rules
> +                    (lambda* (#:key outputs #:allow-other-keys)

I removed the outputs argument...

> +                      (install-file "scripts/49-greaseweazle.rules"
> +                                    (string-append (assoc-ref outputs "out")

... and used (string-append #$output ...)

> +                                                   
> "/lib/udev/rules.d/")))))))
> +    (native-inputs (list python-setuptools-scm))
> +    (propagated-inputs (list python-bitarray python-pyserial python-requests
> +                             python-crcmod))

Indentation is surprising here. I changed it.

> +    (synopsis "Tools for accessing a floppy drive at the raw flux level")
> +    (description
> +     "The host tools for controlling a Greaseweazle: an Open Source USB 
> device
> +capable of reading and writing raw data on nearly any type of floppy disk")

Descriptions should consist of full sentences:

  "This package provides host tools for..."

Regards,
-- 
Nicolas Goaziou