[bug#64151] [PATCH] etc: Stop making sendemail behave strangely.

[Maxim Cournoyer]

Hi Chris,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris,
>
> (Cc: Maxim.)
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> I noticed git send-email misbehaving, adding X-Debbugs-Cc headers that I
>> didn't intend to add. Some patches had X-Debbugs-Cc for myself, which is
>> irritating to me, and others were worse in that they X-Debbugs-Cc'ed other
>> people.
>>
>> * etc/git/gitconfig: Stop affecting sendemail.
>
> I think it was done on purpose, so that the team responsible for the
> code being changed would automatically be notified.

Indeed!  The original idea behind teams was to subscribe to a more
focused scope than the guix-patches list; and commit 1d77fd705b ("doc:
Simplify contributing section by automating git configuration.") made it
ping the teams automatically.  It's documented in info '(guix) Sending a
Patch Series':

   Notifying Teams
   ...............

   If your git checkout has been correctly configured (*note Configuring
   Git::), the ‘git send-email’ command will automatically notify the
   appropriate team members, based on the scope of your changes.  This
   relies on the ‘etc/teams.scm’ script, which can also be invoked
   manually if you do not use the preferred ‘git send-email’ command to
   submit patches.  To list the available actions of the script, you can
   invoke it via the ‘etc/teams.scm help’ command.  For more information
   regarding teams, see *Note Teams::.

> I like the intention, though I understand one might find it a bit
> heavy-handed: we end up Cc’ing lots of people (and apparently this
> hasn’t resulted in an increase of review work, unfortunately).

It did for me in a limited way because I'm only part of the gnome-team
:-).  When Liliana's GNOME patches reach my INBOX I feel compelled to
process them quickly.  I'd otherwise probably easily miss them.

I'd suggest people joining teams only do so if they actually have the
bandwidth to help with the review of the scopes they cover to avoid
feeling overwhelmed.  It's easy to add/remove ourselves to a team.

If you *really* don't want the default configured behavior to happen,
you still can, by adding the '--no-header-cmd' option to your 'git
send-email' invocation, although I'd prefer you use this with a lot of
care, as I want to receive the notifications for the submissions
touching the team I'm subscribed to :-)

If there's something to improve such as not adding a CC to yourself,
that's a good idea and can probably be done in etc/teams.scm.  You can
open an issue for it if you'd like to track its resolution.

Does that clarify things?  If it does and it's acceptable to you, please
close this issue.

-- 
Thanks,
Maxim