[bug#62801] [PATCH 0/4]: gnu: python-astroalign: Update to 2.4.2.

[Maxim Cournoyer]

Hello,

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

> * gnu/packages/astronomy.scm (python-astroscrappy): New variable.
> ---
>  gnu/packages/astronomy.scm | 48 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index db290f5987..f162be6006 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -1302,6 +1302,54 @@ (define-public python-astroquery
>  to access online Astronomical data.  Each web service has its own 
> sub-package.")
>      (license license:bsd-3)))
>  
> +(define-public python-astroscrappy
> +  (package
> +    (name "python-astroscrappy")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "astroscrappy" version))
> +       (sha256
> +        (base32 "0shmfilvzpmlwz4fh0bx4kqmzr0y39fgga6vipxb5d1rx1y6q6by"))))
> +    (build-system pyproject-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'preparations
> +            (lambda _ (setenv "HOME" "/tmp")))
> +          (add-before 'install 'writable-compiler
> +            (lambda _ (make-file-writable "astroscrappy/_compiler.c")))
> +          (add-before 'check 'writable-compiler
> +            (lambda _ (make-file-writable "astroscrappy/_compiler.c")))
> +          (replace 'check
> +            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> +              (when tests?
> +                (add-installed-pythonpath inputs outputs)

The 'add-install-to-pythonpath' is not needed; this is implicitly
already done before the check phase in the python build systems.

> +                ;; Extensions have to be rebuilt before running the tests.
> +                (invoke "python" "setup.py" "build_ext" "--inplace")

I think it'd be a bit cleaner to move this in a distinct phase named
e.g. 'build-extension.  Then the check phase of pyproject-build-system
could be left alone.  If the '--pyargs' argument is really required, it
can be provided via the #:test-flags #~(list "--pyargs" "astroscrappy")
argument.

> +                (invoke "python" "-m" "pytest" "--pyargs" 
> "astroscrappy")))))))
> +    (native-inputs
> +     (list python-cython
> +           python-extension-helpers
> +           python-h5py
> +           python-pandas
> +           python-pytest-astropy
> +           python-scikit-image
> +           python-setuptools-scm
> +           python-scipy))

The last input should appear earlier (sort).

-- 
Thanks,
Maxim