[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62503: emacs-beframe
From: |
Nicolas Goaziou |
Subject: |
bug#62503: emacs-beframe |
Date: |
Thu, 30 Mar 2023 22:50:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
sourcepluck@posteo.net writes:
> Jamie Cullen here. This is my first ever patch, first ever commit,
> first ever packaged package, first ever time doing anything mildly
> useful with Git, etc etc. Excitement is tantamount here.
This sure is a good first patch. Since I had only nitpicks to write,
I applied it directly. Thank you!
> Please don't hesitate to tell me about even the smallest modification
> on my side, and any length of an explanation here via mail.
I wrote below what small changes I made to your package definition.
> +(define-public emacs-beframe
> + (package
> + (name "emacs-beframe")
> + (version "0.2.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~protesilaos/beframe")
> + (commit "edfab6eefe4ac35cd8d1ed87fc7f670496d25e40")))
We don't usually insert commit hashes here, but rather bind hash to
`commit' and put (commit commit) above.
I a comment, I also mentioned the commit was actually a version bump,
which is the reason why there is no revision number.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0sd8r3icaj2gl7f62fyzlwkkb05mc3cwsqgicw0n1x07s5ir3129"))))
> + (build-system emacs-build-system)
> + (native-inputs (list texinfo))
Nitpick: native inputs are usually listed after arguments.
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases
> + %standard-phases
> + (add-after 'install 'makeinfo
> + (lambda* (#:key outputs #:allow-other-keys)
Since you don't use `output' key, (lambda _ ...) is sufficient.
> + (install-file
> + "beframe.info"
> + (string-append #$output "/share/info")))))))
Nitpick: I think a better indentation is:
(install-file "beframe.info"
(string-append #$output "/share/info"))
> + (description
> + "Beframe enables a frame-oriented Emacs workflow where each frame has
> +access to the list of buffers visited therein. In the interest of brevity,
> we
> +call buffers that belong to frames \"beframed\". Producing multiple
> frames does
In Texinfo, double quotes are ``...'', not "...".
Regards,
--
Nicolas Goaziou