[bug#62488] [PATCH] Update emacs-lemon

[Baptiste Strazzulla]

Hello,

Here is two requested updates to the patch

Kind regards,

Baptiste

---

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Sent: Monday, March 27, 2023 5:23 PM
To: Baptiste Strazzulla <bstrazzull@hotmail.fr>
Cc: 62488@debbugs.gnu.org <62488@debbugs.gnu.org>
Subject: Re: [bug#62488] [PATCH] Update emacs-lemon

 

Hello,

Baptiste Strazzulla <bstrazzull@hotmail.fr> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lemon-version): Update to 2.1.0

Thank you.

>  (define-public emacs-lemon
> -  (let ((commit "37a6e6d6ef0900ca19c820a2dbc122c7fe6d86cf")
> +  (let ((commit "b10e992a25757a91723c7d554a5fa8e14291e702")
>          (revision "0"))
>      (package
>        (name "emacs-lemon")
> -      (version (git-version "2.0.0" revision commit))
> +      (version (git-version "2.1.0" revision commit))

Since the commit matches the version bump, you can drop the `revision'
binding and `git-version' call. Version is simply "2.1.0". Could you
send an updated patch?

I noticed the package contains some tests. Would you try to run them, in
a subsequent patch?

Regards,
--
Nicolas Goaziou

0001-gnu-emacs-lemon-Update-to-2.1.0.patch
Description: 0001-gnu-emacs-lemon-Update-to-2.1.0.patch

0002-gnu-emacs-lemon-Add-tests.patch
Description: 0002-gnu-emacs-lemon-Add-tests.patch