[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#62490] [PATCH] services: nginx: Make logging level configurable.
From: |
Maxim Cournoyer |
Subject: |
[bug#62490] [PATCH] services: nginx: Make logging level configurable. |
Date: |
Tue, 28 Mar 2023 10:12:30 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Bruno Victal <mirai@makinata.eu> writes:
> * gnu/services/web.scm (<nginx-configuration>)[log-level]: New field.
> (assert-valid-log-level): New procedure.
> (default-nginx-config): Make log-level configurable.
> * doc/guix.texi (Web Services): Document it.
Thanks!
> ---
>
> Note: Hardcoding this value to 'info is extremely bad for
> flash endurance, and results in very large logs.
>
> doc/guix.texi | 5 +++++
> gnu/services/web.scm | 24 +++++++++++++++++++++++-
> 2 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index c49e51b72e..8df3c285ad 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -29838,6 +29838,11 @@ Web Services
> @item @code{log-directory} (default: @code{"/var/log/nginx"})
> The directory to which NGinx will write log files.
>
> +@item @code{log-level} (default: @code{'error}) (type: symbol)
> +Logging level, which can be any of the following values: @code{'debug},
> +@code{'info}, @code{'notice}, @code{'warn}, @code{'error}, @code{'crit},
> +@code{'alert}, or @code{'emerg}.
> +
> @item @code{run-directory} (default: @code{"/var/run/nginx"})
> The directory in which NGinx will create a pid file, and write temporary
> files.
> diff --git a/gnu/services/web.scm b/gnu/services/web.scm
> index d56e893527..aef694e145 100644
> --- a/gnu/services/web.scm
> +++ b/gnu/services/web.scm
> @@ -51,6 +51,9 @@ (define-module (gnu services web)
> #:use-module (gnu packages logging)
> #:use-module (gnu packages mail)
> #:use-module (gnu packages rust-apps)
> + #:autoload (guix i18n) (G_)
> + #:use-module (guix combinators)
> + #:use-module (guix diagnostics)
> #:use-module (guix packages)
> #:use-module (guix records)
> #:use-module (guix modules)
> @@ -61,6 +64,8 @@ (define-module (gnu services web)
> #:use-module ((guix packages) #:select (package-version))
> #:use-module (srfi srfi-1)
> #:use-module (srfi srfi-9)
> + #:use-module (srfi srfi-34)
> + #:use-module (srfi srfi-35)
> #:use-module (ice-9 match)
> #:use-module (ice-9 format)
> #:export (httpd-configuration
> @@ -96,6 +101,7 @@ (define-module (gnu services web)
> nginx-configuration-nginx
> nginx-configuration-shepherd-requirement
> nginx-configuration-log-directory
> + nginx-configuration-log-level
> nginx-configuration-run-directory
> nginx-configuration-server-blocks
> nginx-configuration-upstream-blocks
> @@ -562,6 +568,9 @@ (define-record-type* <nginx-configuration>
> (default '())) ;list of symbols
> (log-directory nginx-configuration-log-directory ;string
> (default "/var/log/nginx"))
> + (log-level nginx-configuration-log-level
> + (sanitize assert-valid-log-level)
> + (default 'error))
> (run-directory nginx-configuration-run-directory ;string
> (default "/var/run/nginx"))
> (server-blocks nginx-configuration-server-blocks
> @@ -584,6 +593,18 @@ (define-record-type* <nginx-configuration>
> (file nginx-configuration-file ;#f | string | file-like
> (default #f)))
>
> +(define-compile-time-procedure (assert-valid-log-level (level symbol?))
> + "Ensure @var{level} is one of @code{'debug}, @code{'info}, @code{'notice},
> +@code{'warn}, @code{'error}, @code{'crit}, @code{'alert}, or @code{'emerg}."
> + (unless (memq level '(debug info notice warn error crit alert emerg))
> + (raise
> + (make-compound-condition
> + (formatted-message (G_ "unknown log level '~a'") level)
> + (condition (&error-location
> + (location
> + (source-properties->location
> procedure-call-location)))))))
> + level)
It's the first time I've seen define-compile-time-procedure in actual
use. Is it really necessary? What happens if you omit wrapping
assert-valid-log-level with it?
> (define (config-domain-strings names)
> "Return a string denoting the nginx config representation of NAMES, a list
> of domain names."
> @@ -692,6 +713,7 @@ (define (default-nginx-config config)
> (match-record config
> <nginx-configuration>
> (nginx log-directory run-directory
> + log-level
> server-blocks upstream-blocks
> server-names-hash-bucket-size
> server-names-hash-bucket-max-size
> @@ -704,7 +726,7 @@ (define (default-nginx-config config)
> (flatten
> "user nginx nginx;\n"
> "pid " run-directory "/pid;\n"
> - "error_log " log-directory "/error.log info;\n"
> + "error_log " log-directory "/error.log " (symbol->string
> log-level) ";\n"
> (map emit-load-module modules)
> (map emit-global-directive global-directives)
> "http {\n"
The rest LGTM.
--
Thanks,
Maxim