[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60571] activating tests for skia 2D graphics library
From: |
Maxim Cournoyer |
Subject: |
[bug#60571] activating tests for skia 2D graphics library |
Date: |
Thu, 23 Mar 2023 23:15:01 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Nicolas Graves <ngraves@ngraves.fr> writes:
> * gnu/packages/vulkan.scm (spirv-headers-for-skia): New variable.
> ---
> gnu/packages/vulkan.scm | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
> index a2db5511d5..8895d8a5cf 100644
> --- a/gnu/packages/vulkan.scm
> +++ b/gnu/packages/vulkan.scm
> @@ -74,6 +74,23 @@ (define-public spirv-headers
> (string-append
> "https://github.com/KhronosGroup/SPIRV-Headers/blob/"
> version "/LICENSE")))))
>
> +(define-public spirv-headers-for-skia
Could you please add a comment here about why we use this commit, and
not a release, e.g. ("There is no release; use the latest commit.")
> + (let ((commit "814e728b30ddd0f4509233099a3ad96fd4318c07")
> + (revision "0"))
> + (package
> + (inherit spirv-headers)
> + (name "spirv-headers-for-skia")
> + (version "skia")
That's not OK as a version. See if there is a version string in the
source, and use that else 0.0.0, combined wih revision and commit via
the 'git-version' procedure.
Thanks for working on it!
--
Thanks,
Maxim
- [bug#60571] activating tests for skia 2D graphics library,
Maxim Cournoyer <=