[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilat
From: |
Nicolas Goaziou |
Subject: |
[bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation. |
Date: |
Tue, 21 Mar 2023 10:34:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
John Kehayias via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: emacs-buttercup: Fix build with native
> compilation.
Thank you.
> + (add-after 'unpack 'fix-spy-on-test
> + (lambda _
> + (substitute* "buttercup.el"
> + ;; The spy-on test fails with native compilation, which was
> + ;; fixed in v1.30 but with a variable name for Emacs newer
> + ;; than 28.2. Add in the same fix with the current variable
> + ;; name. Upstream bug and fix:
> + ;;
> <https://github.com/jorgenschaefer/emacs-buttercup/issues/236>
> + (("61880") "61880\n(comp-enable-subr-trampolines nil)\n"))))
Nitpick: I'm surprised by the choice of your anchor: 61880 is at the end
of a comment. Wouldn't
(("\\(native-comp-enable-subr-trampolines nil\\)" all)
(string-append all "\n(comp-enable-subr-trampolines nil)"))
be more explicit?
Regards,
--
Nicolas Goaziou