[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-grou
From: |
Liliana Marie Prikler |
Subject: |
[bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-group) for user (resp. group) fields. |
Date: |
Mon, 20 Mar 2023 20:33:05 +0100 |
User-agent: |
Evolution 3.46.0 |
Am Montag, dem 20.03.2023 um 17:07 +0000 schrieb Bruno Victal:
> Deprecate using strings for these fields and prefer user-account
> (resp. user-group) instead to avoid duplication within account-
> service-type. If a string value is encountered, it is ignored and a
> predefined variable is used instead. This is essentially a rollback
> to how it used to be before
> '5c5f0fc1135ff15f9c4adfc5f27eadd9a592b5d1'.
I already wrote this in private in IRC, but falling back to a constant
when a string value is given is very silly. IIUC the reason to do so
is because you would need to sanitize the user account and group at the
same time so that the former has access to the latter.
I think it's possible to use one of the following approaches to get a
better result:
1. In (mpd-accounts), check if the user group equals the group name and
raise a warning (or error) if not.
2. Use a special unique symbol, e.g. (make-symbol "%mpd-group") to
denote the value to be lazily inserted by the serializer.
Cheers
- [bug#62298] [PATCH 0/8] Extensible define-configuration & mpd/mympd service fixes, Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 1/8] services: configuration: Add user-defined sanitizer support., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 5/8] services: mpd: Fix unintentional API breakage for mixer-type field., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 2/8] services: replace bare serializers with (serializer ...), Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 6/8] services: mpd: Set PulseAudio related variables as default value for environment-variables field., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 3/8] services: audio: remove redundant list-of-string? predicate., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-group) for user (resp. group) fields., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 7/8] services: mpd: Use user-account (resp. user-group) for user (resp. group) fields.,
Liliana Marie Prikler <=
- [bug#62298] [PATCH 8/8] services: mympd: Use user-account (resp. user-group) for user (resp. group) fields., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH 4/8] services: mympd: Require 'syslog service when configured to log to syslog., Bruno Victal, 2023/03/20
- [bug#62298] [PATCH v2 1/8] services: configuration: Add user-defined sanitizer support., Bruno Victal, 2023/03/23