[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61587] [PATCH 0/8] networking services refactoring
From: |
Ludovic Courtès |
Subject: |
[bug#61587] [PATCH 0/8] networking services refactoring |
Date: |
Tue, 07 Mar 2023 11:01:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Bruno Victal <mirai@makinata.eu> skribis:
> Note: This also makes wpa-supplicant an optional requirement.
>
> * gnu/services/networking.scm (<network-manager-configuration>)
> [shepherd-requirement]: New field.
> (network-manager-shepherd-service): Honor it.
> (network-manager-configuration-shepherd-requirement): Export accessor.
> * doc/guix.texi (Networking Setup): Document it.
[...]
> +@item @code{shepherd-requirement} (default: @code{()})
> +This option can be used to provide a list of symbols naming Shepherd services
> +that this service will depend on, such as @code{'wpa-supplicant} or
> +@code{'iwd} if you require authenticated access for encrypted WiFi or
> Ethernet
> +networks.
For clarity, I’d write the list: @code{'(wpa-supplicant)}.
> + (shepherd-requirement network-manager-configuration-shepherd-requirement
> + (default '()))
[...]
> - (requirement (append '(user-processes dbus-system loopback)
> - (if iwd? '(iwd) '(wpa-supplicant))))
> + (requirement `(user-processes dbus-system loopback
> + ,@shepherd-requirement
> + ,@(if iwd? '(iwd) '())))
To preserve backward compatibility and to provide a reasonable default
(with working WiFi), I think the default for ‘shepherd-requirement’
should be '(wpa-supplicant) rather than the empty list.
(BTW, it seems that wpa-supplicant can be DBus-activated, maybe that’s
what we should do instead? But let’s forget about it for this patch
series.)
Thanks,
Ludo’.
- [bug#61587] [PATCH v2 1/8] services: network-manager: Add 'shepherd-requirement' field., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 8/8] services: connman: Set service canonical-name to connman., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 5/8] services: connman: Deprecate 'iwd?' field., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 4/8] services: connman: Add 'shepherd-requirement' field., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 2/8] services: network-manager: Deprecate 'iwd?' field., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 3/8] services: connman: Use match-record and export accessors., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 6/8] services: network-manager: Await for NetworkManager to finish starting up., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH v2 7/8] services: network-manager: Set service canonical-name to NetworkManager., Bruno Victal, 2023/03/03
- [bug#61587] [PATCH 0/8] networking services refactoring,
Ludovic Courtès <=